[
https://issues.apache.org/jira/browse/OAK-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh updated OAK-3576:
-------------------------------
Attachment: OAK-3576.take2.patch
Attaching take2 [patch|^OAK-3576.take2.patch]. Both SPI now has
{{getSupportedTypes}}. Comparison with types provided by implementation is
exact string match against {{IndexingRule.getNodeTypeName()}} (on query side,
the rule is derived from {{PlanResult}}).
Have moved to tracker based implementation, but I've a few things which I don't
know for sure:
* {{LuceneIndexAugmentFactory}} now takes {{Whiteboard}} in contsructor.
{{LuceneIndexProviderService}} passes the whiteboard instance -- not sure if I
should have passed specific {{Tracker}} instances instead.
* Since {{Tracker}} just gives {{getServices}}, LuceneIndexProviderService
registers for multi-ref over SPI interfaces and just sends a call to
{{LuceneIndexAugmentFactory.refreshServices}} to notify to update references to
implementation services. In the call, I'm clearing a Map and filling it up with
lists from getServices. -- I don't know about thread safety here.
* I've tried to add test cases to cover most cases but I wasn't sure of testing
LuceneIndexProviderService sending refresh calls.
[~chetanm], can you please review this.
> Allow custom extension to augment indexed lucene documents
> ----------------------------------------------------------
>
> Key: OAK-3576
> URL: https://issues.apache.org/jira/browse/OAK-3576
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
> Reporter: Vikas Saurabh
> Assignee: Vikas Saurabh
> Fix For: 1.4
>
> Attachments: OAK-3576.jsedding.patch, OAK-3576.take2.patch,
> OAK-3576.wip.patch
>
>
> Following up on http://oak.markmail.org/thread/a53ahsgb3bowtwyq, we should
> have an extension point in oak to allow custom code to add fields to
> documents getting indexed in lucene. We'd also need to allow extension point
> to add extra query terms to utilize such augmented fields.
> (cc [~teofili], [~chetanm])
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
