[
https://issues.apache.org/jira/browse/OAK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094883#comment-15094883
]
Michael Dürig commented on OAK-3869:
------------------------------------
See
https://github.com/mduerig/jackrabbit-oak/commit/35f6ada085046a46f061788776917d53915ad6c1
for an attempt to regain type safety. I don't like it too much though as it
doesn't work for all record types. See e.g. [{{newValueWriter()}} |
https://github.com/mduerig/jackrabbit-oak/blob/35f6ada085046a46f061788776917d53915ad6c1/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/RecordWriters.java#L107],
which I had to parametrise with just {{Record}} as a value might represent an
entry in a list, a property, a value, etc..
> Refactor RecordWriter.write to always return a RecordId
> -------------------------------------------------------
>
> Key: OAK-3869
> URL: https://issues.apache.org/jira/browse/OAK-3869
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: segmentmk
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Labels: technical_debt
>
> I think it would be cleaner if {{RecordId.write}} would always return a
> {{RecordId}} instead of depending on its type parametrisation and would like
> to refactor it to that respect..
> This is also a pre-requisite for my work on OAK-3348 and might also be for
> OAK-3864.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
