[ 
https://issues.apache.org/jira/browse/OAK-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098331#comment-15098331
 ] 

Julian Sedding commented on OAK-3862:
-------------------------------------

Not sure what people mean when they say "move to dedicated IT module".

# Create a new IT module and run tests with potentially all fixtures in this 
module
# Create a new IT module that defines implementation-agnostic test, run the 
tests in the various (future) persistence modules (e.g. 
oak-persistence-segment, oak-persistence-document, etc.)

If it's #1, I am -0 as I don't think that's an elegant approach. However, it's 
pragmatic and solves the immediate problem.

I think #2 is the nicer approach, as it would essentially provide a test kit 
that could be easily re-used even for implementations outside the Jackrabbit 
project (similar to the JCR TCK). However, this is presumably slightly more 
work to achieve.



> Move integration tests in a different Maven module
> --------------------------------------------------
>
>                 Key: OAK-3862
>                 URL: https://issues.apache.org/jira/browse/OAK-3862
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: 1.4
>
>
> While moving the Segment Store and related packages into its own bundle, I 
> figured out that integration tests contained in {{oak-core}} contribute to a 
> cyclic dependency between the (new) {{oak-segment}} bundle and {{oak-core}}.
> The dependency is due to the usage of {{NodeStoreFixture}} to instantiate 
> different implementations of {{NodeStore}} in a semi-transparent way.
> Tests depending on {{NodeStoreFixture}} are most likely integration tests. A 
> clean solution to this problem would be to move those integration tests into 
> a new Maven module, referencing the API and implementation modules as needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to