[
https://issues.apache.org/jira/browse/OAK-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106393#comment-15106393
]
Thomas Mueller commented on OAK-3881:
-------------------------------------
Thanks a lot! The patch looks good to me.
> TCPBroadcaster causes shutdown delay
> ------------------------------------
>
> Key: OAK-3881
> URL: https://issues.apache.org/jira/browse/OAK-3881
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core, documentmk
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Fix For: 1.4
>
> Attachments: OAK-3881.patch
>
>
> OAK-3727 enabled the broadcasting cache by default. With this change the
> shutdown of a DocumentNodeStore gets delayed by roughly one second. This is
> also visible in the time it takes to run the tests on travis. Previously the
> build took 35 min. The build with OAK-3727 took 45 minutes.
> A thread dump shows the following threads:
> {noformat}
> "Oak TCPBroadcaster: discover #50" daemon prio=5 tid=0x00007f8957837800
> nid=0x5e13 waiting on condition [0x0000000116b5b000]
> java.lang.Thread.State: TIMED_WAITING (sleeping)
> at java.lang.Thread.sleep(Native Method)
> at
> org.apache.jackrabbit.oak.plugins.document.persistentCache.broadcast.TCPBroadcaster.discover(TCPBroadcaster.java:268)
> at
> org.apache.jackrabbit.oak.plugins.document.persistentCache.broadcast.TCPBroadcaster$2.run(TCPBroadcaster.java:155)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> And the shutdown waiting for above thread:
> {noformat}
> "main" prio=5 tid=0x00007f8954000800 nid=0x1303 in Object.wait()
> [0x000000010cd5e000]
> java.lang.Thread.State: WAITING (on object monitor)
> at java.lang.Object.wait(Native Method)
> - waiting on <0x00000007f6c80e10> (a java.lang.Thread)
> at java.lang.Thread.join(Thread.java:1281)
> - locked <0x00000007f6c80e10> (a java.lang.Thread)
> at java.lang.Thread.join(Thread.java:1355)
> at
> org.apache.jackrabbit.oak.plugins.document.persistentCache.broadcast.TCPBroadcaster.close(TCPBroadcaster.java:379)
> at
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache.close(PersistentCache.java:346)
> at
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.dispose(DocumentNodeStore.java:581)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
