[ 
https://issues.apache.org/jira/browse/OAK-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Parvulescu updated OAK-3988:
---------------------------------
    Description: 
OAK-3965 uncovered an issue with the {{size}} calls on PropertyNodeStates when 
dealing with external binaries, and the fix effectively breaks offline 
compaction on repos with external data stores.

The issue is twofold:
* OAK-3965 breaks offline compaction in certain setups
* the current code puts all the nodes with an external binary in the compaction 
map, skipping the size filter

I think the offline compactor should basically ignore the external binaries in 
checking if a node meets the compaction map criteria or not.

  was:
OAK-3965 uncovered an issue with the {{size}} calls on PropertyNodeStates when 
dealing with external binaries, and the fix effectively breaks offline 
compaction on repos with external data stores.
I think the offline compactor should basically ignore the external binaries in 
checking if a node meets the compaction map criteria or not.


> Offline compaction should avoid loading external binaries
> ---------------------------------------------------------
>
>                 Key: OAK-3988
>                 URL: https://issues.apache.org/jira/browse/OAK-3988
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>
> OAK-3965 uncovered an issue with the {{size}} calls on PropertyNodeStates 
> when dealing with external binaries, and the fix effectively breaks offline 
> compaction on repos with external data stores.
> The issue is twofold:
> * OAK-3965 breaks offline compaction in certain setups
> * the current code puts all the nodes with an external binary in the 
> compaction map, skipping the size filter
> I think the offline compactor should basically ignore the external binaries 
> in checking if a node meets the compaction map criteria or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to