[ 
https://issues.apache.org/jira/browse/OAK-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138943#comment-15138943
 ] 

Thomas Mueller commented on OAK-3973:
-------------------------------------

As for formatting:

{noformat}
if (selector.isVirtualRow()) return true;
{noformat}

This should be changed to:

{noformat}
if (selector.isVirtualRow()) {
    return true;
}
{noformat}


> There should be a way to get filtered suggestions based on some path
> --------------------------------------------------------------------
>
>                 Key: OAK-3973
>                 URL: https://issues.apache.org/jira/browse/OAK-3973
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: lucene
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>             Fix For: 1.6
>
>         Attachments: OAK-3973.wip.patch
>
>
> Currently, suggestions are indexed at index level - so, when querying for 
> suggestions, the result incorporates all documents indexed by that document.
> So, this doesn't allow filtering suggestions for a subset of indexed document 
> - at least we should be able to get filtered suggestion based on a root path.
> This seems very similar to a functionality provided by lucene vide 
> LUCENE-5528 which was fixed in lucene 4.8. Since oak is still on 4.7, so, we 
> can't exploit that feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to