[
https://issues.apache.org/jira/browse/OAK-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150591#comment-15150591
]
angela edited comment on OAK-3886 at 2/17/16 2:59 PM:
------------------------------------------------------
[~tripod], thanks for reviewing... regarding {{...has an unrelated change}} in
{{ExternalLoginModuleFactory}}: i know ;-) also in the doc update. the latter
have been committed in the mean time and so will the changes for
{{ExternalLoginModuleFactory}} and test before I start pushing any changes here
:-)
One more thing: We might also consider moving the interface to the regular
authentication package... I will give this a second thought and see if that
feels right.
was (Author: anchela):
[~tripod], thanks for reviewing... regarding {{...has an unrelated change}} in
{{ExternalLoginModuleFactory}}: i know ;-) also in the doc update. the latter
have been committed in the mean time and so will the changes for
{{ExternalLoginModuleFactory}} and test before I start pushing any changes here
:-)
> Delegate supported Credentials types to ExternalIdentityProvider
> ----------------------------------------------------------------
>
> Key: OAK-3886
> URL: https://issues.apache.org/jira/browse/OAK-3886
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
> Reporter: Alexander Klimetschek
> Attachments: OAK-3886.patch
>
>
> Currently, the ExternalLoginModule [only supports
> SimpleCredentials|https://github.com/apache/jackrabbit-oak/blob/cc78f6fdd122d1c9f200b43fc2b9536518ea996b/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java#L415-L419].
> As the TODO says, it would be good to allow the ExternalIdentityProvider
> specify the supported types, in case they have custom authentication schemes
> that don't fit the username + password pattern of the SimpleCredentials.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
