[
https://issues.apache.org/jira/browse/OAK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167007#comment-15167007
]
Thomas Mueller commented on OAK-3850:
-------------------------------------
I had to change the patch slightly as I couldn't apply it (using Eclipse). Just
one case couldn't be applied automatically, NodeCache.get.
As for your comment above:
{noformat}
PersistentCache with stats + MetricsStatisticsProvider ( ~ 46 sec )
PersistentCache with stats + StatististicsProvider.NOOP (~ 40-41 sec )
PersistentCache without stats = current oak trunk ( ~ 40-41 sec )
{noformat}
10% degradation sounds problematic. Maybe we should use
StatististicsProvider.NOOP by default, and only use MetricsStatisticsProvider
if explicitly configured? What do you think?
> Collect and expose Persistent Cache stats
> -----------------------------------------
>
> Key: OAK-3850
> URL: https://issues.apache.org/jira/browse/OAK-3850
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, documentmk
> Reporter: Teodor Rosu
> Assignee: Thomas Mueller
> Fix For: 1.4
>
> Attachments: OAK-3850-v0.patch, OAK-3850-v1.patch, OAK-3850-v2.patch,
> test-performance-v0.patch
>
>
> Expose persistent cache statistics ( see: [Guava
> CacheStats|http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/cache/CacheStats.html]
> )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
