[
https://issues.apache.org/jira/browse/OAK-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15168151#comment-15168151
]
Teodor Rosu edited comment on OAK-3850 at 2/26/16 6:59 AM:
-----------------------------------------------------------
There are two timers, both configurable ( PersistentCacheStats.java ):
1. loadTimer - measure the time to load an entry from the layer below ( e.g.
DocumentStore )
2. readTImer - measure the time to read an entry from the PersistentCache (
from MVStore )
As mentioned, both timed operations are fast ( majority of calls < 1 ms ).
Personal opinion: we should set these two metrics as noop timers as defaults (
or remove them ).
was (Author: rosu):
There are two timers, both configurable ( PersistentCacheStats.java ):
1. loadTimer - measure the time to load an entry from the layer below ( e.g.
DocumentStore )
2. readTImer - measure the time to read an entry from the PersistentCache (
from MVStore )
As mentioned, both timed operations are fast ( under 1 ms ). Personal opinion:
set these two metrics as noop timers as defaults ( or remove them ).
> Collect and expose Persistent Cache stats
> -----------------------------------------
>
> Key: OAK-3850
> URL: https://issues.apache.org/jira/browse/OAK-3850
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, documentmk
> Reporter: Teodor Rosu
> Assignee: Thomas Mueller
> Fix For: 1.4
>
> Attachments: OAK-3850-v0.patch, OAK-3850-v1.patch, OAK-3850-v2.patch,
> estimated-space.patch, test-performance-v0.patch
>
>
> Expose persistent cache statistics ( see: [Guava
> CacheStats|http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/cache/CacheStats.html]
> )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
