[ 
https://issues.apache.org/jira/browse/OAK-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173770#comment-15173770
 ] 

angela edited comment on OAK-3933 at 3/3/16 3:59 PM:
-----------------------------------------------------

additional ideas:
- reconsider the current threshold of 100 entries per {{rep:members}} property 
(=> benchmarks needed to find the optimal value)
- use {{PropertyState.count()}} to identify the best property to append the new 
value(s) (=> this might require some improvements to the 
{{DocumentPropertyState}} which needs to parse the property in order to 
determine the number of values afaik).
- keep track of the newest ref-list-node and only append there (=> ignoring the 
fact that the count of some member-properties might shrink due to 
member-removal)
- {{MembershipProvider.addMembers}} that takes multiple memberIDs and thus only 
scans existing members once (instead of doing this for every single member id)
- {{Group.addMember}} contains an extra check for circular membership (as 
present in Jackrabbit 2.x), which is not present in {{Group.addMembers}}; we 
might consider dropping this in the first case as the {{UserValidator}} should 
take care of this.


was (Author: anchela):
additional ideas:
- reconsider the current threshold of 100 entries per {{rep:members}} property 
(=> benchmarks needed to find the optimal value)
- use {{PropertyState.count()}} to identify the best property to append the new 
value(s) (=> this might require some improvements to the 
{{DocumentPropertyState}} which needs to parse the property in order to 
determine the number of values afaik).
- keep track of the newest ref-list-node and only append there (=> ignoring the 
fact that the count of some member-properties might shrink due to 
member-removal)
- {{MembershipProvider.addMembers}} that takes multiple memberIDs and thus only 
scans existing members once (instead of doing this for every single member id)
- 

> potential improvements to membership management
> -----------------------------------------------
>
>                 Key: OAK-3933
>                 URL: https://issues.apache.org/jira/browse/OAK-3933
>             Project: Jackrabbit Oak
>          Issue Type: Epic
>          Components: core
>            Reporter: Julian Reschke
>            Assignee: angela
>
> Affected methods are
> - Group.isMember(Authorizable)
> - Group.isDeclaredMember(Authorizable)
> - Group.addMember(Authorizable)
> - Group.addMembers(String...)
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to