[
https://issues.apache.org/jira/browse/OAK-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253956#comment-15253956
]
Alex Parvulescu commented on OAK-4211:
--------------------------------------
+1 for the releasing of the buffer
the other changes, I'm not too happy about:
* first, closing the file will also close the channel if open [0]
* second, the (possible) exception is lost, and at the very least it needs to
be logged, as was decided a while back when changing this code [1]
[0]
http://docs.oracle.com/javase/6/docs/api/java/io/RandomAccessFile.html#close()
[1]
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-next/src/main/java/org/apache/jackrabbit/oak/segment/file/FileStore.java#L1178
> FileAccess.Mapped leaks file channels
> --------------------------------------
>
> Key: OAK-4211
> URL: https://issues.apache.org/jira/browse/OAK-4211
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-next
> Reporter: Michael Dürig
> Fix For: 1.6
>
> Attachments: OAK-4211-02.patch, OAK-4211.patch
>
>
> {{FileAccess.Mapped}} seems to leak {{FileChannnel}} instances. The file
> channels are acquired in the constructor but never release.
> FYI [~alex.parvulescu], [~frm]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
