[ 
https://issues.apache.org/jira/browse/OAK-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig updated OAK-4278:
-------------------------------
    Description: 
{{FileStoreBackup}} and {{FileStoreRestore}} are currently broken as a side 
effect of the fix from OAK-3348. ({{FileStoreBackupTest}} is currently being 
skipped). 

In {{oak-segment}} backup and restore functionality relied on the {{Compactor}} 
class. The latter is gone in {{oak-segment-next}} as it is not needed for 
online compaction any more. 
Instead of sharing functionality from compaction directly, I think backup and 
restore should come up with its own implementation that could be individually 
tweaked for its task. If there is commonalities with offline compaction those 
can still be shared thorough a common base class. See OAK-4279

  was:
{{FileStoreBackup}} and {{FileStoreRestore}} are currently broken as a side 
effect of the fix from OAK-3348. ({{FileStoreBackupTest}} is currently being 
skipped). 

In {{oak-segment}} backup and restore functionality relied on the {{Compactor}} 
class. The latter is gone in {{oak-segment-next}} as it is not needed for 
online compaction any more. 
Instead of sharing functionality from compaction directly, I think backup and 
restore should come up with its own implementation that could be individually 
tweaked for its task. If there is commonalities with offline compaction those 
can still be shared thorough a common base class. 


> Fix backup and restore
> ----------------------
>
>                 Key: OAK-4278
>                 URL: https://issues.apache.org/jira/browse/OAK-4278
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: segment-next
>            Reporter: Michael Dürig
>              Labels: backup, restore, technical_debt
>
> {{FileStoreBackup}} and {{FileStoreRestore}} are currently broken as a side 
> effect of the fix from OAK-3348. ({{FileStoreBackupTest}} is currently being 
> skipped). 
> In {{oak-segment}} backup and restore functionality relied on the 
> {{Compactor}} class. The latter is gone in {{oak-segment-next}} as it is not 
> needed for online compaction any more. 
> Instead of sharing functionality from compaction directly, I think backup and 
> restore should come up with its own implementation that could be individually 
> tweaked for its task. If there is commonalities with offline compaction those 
> can still be shared thorough a common base class. See OAK-4279



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to