[
https://issues.apache.org/jira/browse/OAK-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256097#comment-15256097
]
angela commented on OAK-4302:
-----------------------------
[~frm], you are perfectly right about {{testGetIdentityRefSyncGroup}} and
{{testGetIdentityRefSyncUser}}; the latter should obviously test the
identity-ref for a synced user.
the other tests however are indeed slightly different as they test different
ways of creating a binary value; so false alarm i'd say :-)
> DefaultSyncContextTest contains duplicate tests
> -----------------------------------------------
>
> Key: OAK-4302
> URL: https://issues.apache.org/jira/browse/OAK-4302
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: auth-external
> Reporter: Francesco Mari
> Assignee: angela
> Fix For: 1.6
>
>
> Some test methods in {{DefaultSyncContextTests}} are the same when compared
> line-by-line:
> * {{testCreateValueFromBytesArray}}, {{testCreateValueFromBinary}} and
> {{testCreateValueFromInputStream}};
> * {{testGetIdentityRefSyncGroup}} and {{testGetIdentityRefSyncUser}}.
> If these methods are actually testing different things because of a lucky
> state of the instance variable and an even luckier running order, they should
> be reworked to be independent. Otherwise, some of them should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
