[ 
https://issues.apache.org/jira/browse/OAK-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258080#comment-15258080
 ] 

Michael Dürig commented on OAK-4284:
------------------------------------

As discussed offline with [~alex.parvulescu] and [~frm] we could run a cleanup 
(brutal) cycle after a unsuccessful compaction. That cleanup cycle would remove 
all segments of exactly the generation added by the (unsuccessful) compaction 
step. To make this work we could generalise {{TarReader#mark}} to take e.g. a 
predicate instead a cutoff generation. 

> Garbage left behind when compaction does not succeed
> ----------------------------------------------------
>
>                 Key: OAK-4284
>                 URL: https://issues.apache.org/jira/browse/OAK-4284
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-next
>            Reporter: Michael Dürig
>              Labels: cleanup, compaction, gc
>             Fix For: 1.6
>
>
> As a result of the new cleanup approach introduced with OAK-3348 (brutal) a 
> compaction cycle that is not successful (either because of cancellation of 
> because of giving up waiting for the lock) leaves garbage behind, which is 
> only cleaned up 2 generations later. 
> We should look into ways to remove such garbage more pro-actively. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to