[ 
https://issues.apache.org/jira/browse/OAK-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260364#comment-15260364
 ] 

Vikas Saurabh commented on OAK-4313:
------------------------------------

Thanks for the patch [~tmueller]. I think TraversingCursor should not traverse 
even for rep:similar case. That rep:similar throws and not return false like 
others (spellcheck and suggest) should probably be corrected separately (may be 
a new issue relating to this one and OAK-2548).

Tested a modified version (removed {{justOneRow}} and assert scanCount as 0) 
which works for current oak-lucene and patched oak-core (also, requires 
adjusting *sql2_native.txt similar to 
[r1662456|https://svn.apache.org/r1662456]).

I'd like to commit the simplified patch as you suggested (opened OAK-4317 to 
align SimilarImpl with SuggestImpl and SpellcheckImpl).

> QueryImpl should avoid traversal with queries containing native constraints
> ---------------------------------------------------------------------------
>
>                 Key: OAK-4313
>                 URL: https://issues.apache.org/jira/browse/OAK-4313
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: query
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Blocker
>              Labels: candidate_oak_1_2, candidate_oak_1_4
>             Fix For: 1.6, 1.4.2
>
>         Attachments: OAK-4313.patch
>
>
> If no index supports suggestion (or spellcheck or similar) query, then a 
> query like
> {noformat}
> SELECT * from [nt:base] where SUGGEST('test')
> {noformat}
> shouldn't get traversing index



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to