[
https://issues.apache.org/jira/browse/OAK-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310578#comment-15310578
]
Michael Dürig commented on OAK-4278:
------------------------------------
The generation should be the same as the one of the target store. Otherwise we
risk funky things happening on a subsequent cleanup. See
{{FileStore#getGcGeneration}} (which we maybe should make public).
> Fix backup and restore
> ----------------------
>
> Key: OAK-4278
> URL: https://issues.apache.org/jira/browse/OAK-4278
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: segment-tar
> Reporter: Michael Dürig
> Assignee: Alex Parvulescu
> Priority: Blocker
> Labels: backup, restore, technical_debt
> Fix For: 1.6
>
> Attachments: OAK-4278-v0.patch
>
>
> {{FileStoreBackup}} and {{FileStoreRestore}} are currently broken as a side
> effect of the fix from OAK-3348. ({{FileStoreBackupTest}} is currently being
> skipped).
> In {{oak-segment}} backup and restore functionality relied on the
> {{Compactor}} class. The latter is gone in {{oak-segment-next}} as it is not
> needed for online compaction any more.
> Instead of sharing functionality from compaction directly, I think backup and
> restore should come up with its own implementation that could be individually
> tweaked for its task. If there is commonalities with offline compaction those
> can still be shared thorough a common base class. See OAK-4279
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
