[
https://issues.apache.org/jira/browse/OAK-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339132#comment-15339132
]
Marcel Reutegger commented on OAK-2919:
---------------------------------------
Thanks for looking into this issue. Regarding the number of changes,
in general I think that's fine because, as you mentioned, the package
is not exported. Maybe we can further limit the changes if we keep
DocumentMK.Builder as a test class, extending the newly introduced
builder. What is the purpose of the enum you want to introduce for the
store types? Can we use generics instead to 'open' up the builder?
> Refactor DocumentNodeStoreService and dependencies
> --------------------------------------------------
>
> Key: OAK-2919
> URL: https://issues.apache.org/jira/browse/OAK-2919
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: blob, mongomk
> Reporter: Philipp Suter
> Labels: technical_debt
>
> Change how DocumentNodeStoreService, DocumentNodeStore, DocumentStore,
> BlobStore, DocumentMK.Builder are wired. It is unclear why
> registerNodeStoreIfPossible and registerNodeStore need additional logic to
> load the right BlobStore and DocumentStore.
> - Ideally (Document)NodeStore references one DocumentStore and one BlobStore.
> Configuration for them are loaded over respective OSGi configurations.
> - Cache should be handled in (Document)NodeStore and be independent from
> DocumentStore, BlobStore.
> - DocumentMK.Builder and DocumentNodeStoreService should be obsolete.
> - DocumentNodeStore is too long and could ideally be split in smaller files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
