[ 
https://issues.apache.org/jira/browse/OAK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348341#comment-15348341
 ] 

Julian Reschke edited comment on OAK-4494 at 6/24/16 2:44 PM:
--------------------------------------------------------------

I'm trying to match {{_MODIFIED}} as well, but the code in 
{{resurrectInvalidate}} doesn't even set it, so {{RDBDocumentStore}} sees two 
entries with value 0. Why does this work for {{MongoDocumentStore}}?

EDIT: it's because {{stamp.modified}} is a {{long}} that gets set to -1 if 
{{_modified}} is not set. Thus {{Objects.equal()}} will return {{false}} when 
comparing to the {{null}} returned by the {{NodeDocument}}. I can match that 
behavior in {{RDBDocumentStore}}, but this looks a bit as if this wasn't really 
intentional. Furthermore, the test doesn't really test what it should test, 
right?


was (Author: reschke):
I'm trying to match {{_MODIFIED}} as well, but the code in 
{{resurrectInvalidate}} doesn't even set it, so {{RDBDocumentStore}} sees two 
entries with value 0. Why does this work for {{MongoDocumentStore}}?

> Stale documents after revision GC in cluster
> --------------------------------------------
>
>                 Key: OAK-4494
>                 URL: https://issues.apache.org/jira/browse/OAK-4494
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, documentmk, mongomk, rdbmk
>            Reporter: Marcel Reutegger
>            Assignee: Julian Reschke
>            Priority: Minor
>              Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
>             Fix For: 1.6
>
>         Attachments: OAK-4494.patch, OAK-4494.patch
>
>
> Implement additional tests for revision GC in a cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to