[
https://issues.apache.org/jira/browse/OAK-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352441#comment-15352441
]
Marcel Reutegger commented on OAK-4514:
---------------------------------------
So far we made sure the test doesn't close the store twice. Well, except for
this one ;)
For now, I would change the test, but in the long run it may be better to have
the same behavior for all implementations. I'd say if there is no way to find
out whether a store is disposed already, then the store should not throw on
multiple dispose calls. Otherwise we should add a method that allows you to
check whether a store is already disposed. I prefer the first.
> AbstractDocumentStore to cleanup may interfere with DS disposal
> ---------------------------------------------------------------
>
> Key: OAK-4514
> URL: https://issues.apache.org/jira/browse/OAK-4514
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
>
> {{AbstractDocumentStore}} current calls {{dispose}} on {{DocumentStore}}
> instances when cleaning up.
> This interferes with {{ResurrectNodeAfterRevisionGCTest}} which creates node
> store instances on top of the document stores, and calls {{dispose()} on
> them, leading to multiple calls to {{dispose}} on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
