[
https://issues.apache.org/jira/browse/OAK-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382312#comment-15382312
]
Michael Dürig commented on OAK-4558:
------------------------------------
Changed issue type to improvement as I don't think anything is broken here. I
agree with the performance considerations though, we should definitely get some
insight on how this is affecting us and whether we need to improve it.
When I implemented the current approach within OAK-3348 it was the simplest
thing to do. A properly inlined id is surely the cleaner approach.
> SegmentNodeState.fastEquals() can trigger two I/O operations
> ------------------------------------------------------------
>
> Key: OAK-4558
> URL: https://issues.apache.org/jira/browse/OAK-4558
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Francesco Mari
> Assignee: Francesco Mari
> Labels: performance
> Fix For: Segment Tar 0.0.6
>
>
> The implementation of {{SegmentNodeState.fastEquals()}} compares the stable
> IDs of two instances of {{SegmentNodeState}}. In some cases, reading the
> stable ID would trigger a read of an additional record, the block record
> containing the serialized version of the segment ID.
> This issue is about evaluating the performance implications of this strategy
> and, in particular, if it would be better to store the serialized stable ID
> in the node record itself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
