[
https://issues.apache.org/jira/browse/OAK-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409160#comment-15409160
]
Michael Dürig commented on OAK-4640:
------------------------------------
I actually like this approach better than what we eventually came up with on
the list. So +1 in general.
* Regarding naming: what about {{CommitContext}}?
* I wouldn't put specific accessors into {{CommitInfo}}. The case for path is a
bad example IMO and it shouldn't have been put there in the first place (blame
on me).
* Equality is a concern though. The {{equals}} implementation was put there on
purpose for OAK-1332. So we should better be careful here.
> Provide a way for commit hook to record meta data for a given commit
> --------------------------------------------------------------------
>
> Key: OAK-4640
> URL: https://issues.apache.org/jira/browse/OAK-4640
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Fix For: 1.6
>
> Attachments: OAK-4640-v1.patch
>
>
> Currently as part of commit the caller can provide a CommitInfo instance
> which captures some metadata related to commit being performed. Note that
> CommitInfo instance passed to NodeStore is immutable.
> For some usecases we need a way to add some more metadata to on going
> commit from within the CommitHook
> * OAK-4586 - Here we need to record nodetypes of nodes which got modified as
> part of current commit
> * OAK-4412 - Here we want to generate Documents for modified nodestate (per
> index definition) and "attach" it to current commit
> This meta information would later be used by Observer.
> To enable such cases some mutable state needs to be exposed as part of
> CommitInfo which can be used by CommitHooks.
> As per discussion of DL [1] this can be done by adding a new
> {{CommitAttributes}} instance which can be accessed from {{CommitInfo}}
> [1]
> http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201608.mbox/%3CCAHCW-mk%3DTMQ_q20dPSmdr7Q%3DcR8OfMDdJceDTd-pGs0pk_cK0g%40mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
