[ 
https://issues.apache.org/jira/browse/OAK-4005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409269#comment-15409269
 ] 

angela commented on OAK-4005:
-----------------------------

which as you can easily lookup explicitly mentions that this might be really 
expensive. so, the original author already had and idea that this is going to 
be troublesome.

IMHO, we should deprecate the _all_-methods and drop them later on.

> LdapIdentityProvider.getEntries() is prone to OOME.
> ---------------------------------------------------
>
>                 Key: OAK-4005
>                 URL: https://issues.apache.org/jira/browse/OAK-4005
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: auth-ldap
>    Affects Versions: 1.2.11, 1.3.15, 1.0.27, 1.4.0
>            Reporter: Manfred Baedke
>            Assignee: Manfred Baedke
>            Priority: Minor
>             Fix For: 1.6
>
>
> The public methods LdapIdentityProvider.listUsers() and 
> LdapIdentityProvider.listGroups() both call 
> LdapIdentityProvider.getEntries(...), which tries to collect all matching 
> results from the backend in one LinkedList. Since typical LDAP directories 
> are quite huge, this will usually yield an OutOfMemoryError.
> We'd need a cursor with connection handling here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to