[ https://issues.apache.org/jira/browse/OAK-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Dulceanu updated OAK-4669: --------------------------------- Attachment: OAK-4669-01.patch [~mduerig], I followed your advice and changed the way the decision about rewriting the TAR file is made. Now there are two sizes computed, {{sweptEntriesSize}} and {{currentEntriesSize}}, both of them being based on entries only (no indices). Could you please take a look at the patch? > Cleanup creates new generation of tar file without removing any segments > ------------------------------------------------------------------------- > > Key: OAK-4669 > URL: https://issues.apache.org/jira/browse/OAK-4669 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-tar > Affects Versions: Segment Tar 0.0.8 > Reporter: Andrei Dulceanu > Assignee: Andrei Dulceanu > Priority: Minor > Labels: cleanup, gc > Fix For: Segment Tar 0.0.10 > > Attachments: OAK-4669-01.patch, test case.patch > > > On some deployments I have seen tar files with a quite hight generation > post-fix (e.g. 'v'). From the log files I could deduce that this particular > tar file was rewritten multiple times without actually any segment being > removed. > I assume this is caused by the 25% gain threshold not taking the sizes > contributed by the index and the graph entries into account. > The attached test case can be used to verify the above hypothesis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)