[ 
https://issues.apache.org/jira/browse/OAK-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominique Jäggi updated OAK-3523:
---------------------------------
    Fix Version/s: 1.2.19

> DefaultSyncContext catches ClassCastException
> ---------------------------------------------
>
>                 Key: OAK-3523
>                 URL: https://issues.apache.org/jira/browse/OAK-3523
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-external
>            Reporter: angela
>            Assignee: angela
>              Labels: technical_debt
>             Fix For: 1.4, 1.3.9, 1.2.19
>
>         Attachments: OAK-3523_classcast_only.patch
>
>
> the group and group-member sync code in the {{DefaultSyncContext}} twice 
> catches {{ClassCastException}} and swallows exception situations, where a 
> user is found, when actually a {{Group}} was expected.
> i would suggest to 
> - explicitly test the assumption wrt {{ExternalIdentity}} being a group 
> (instead of waiting for the exception)
> - make use of {{UserManager.getAuthorizable(String, Class) to explicitly 
> retrieve a Group with a given ID, when this is actually expected. This method 
> will throws an {{AuthorizableTypeException}} if there exists a {{User}} with 
> that ID as thus properly raise the unexpected behavior instead of swallowing 
> with a log-warning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to