[ https://issues.apache.org/jira/browse/OAK-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426665#comment-15426665 ]
Michael Dürig commented on OAK-4618: ------------------------------------ I think we should go deeper than this and also remove the associated {{TimeSeriesRecorder}} instances. And while we are at it, it seems like {{gcCount}} is not used anywhere. We should either remove it or expose it as a simple counter of the number of gc cycles. > Align GCMonitorMBean MBean with new generation based GC > ------------------------------------------------------- > > Key: OAK-4618 > URL: https://issues.apache.org/jira/browse/OAK-4618 > Project: Jackrabbit Oak > Issue Type: Task > Components: segment-tar > Reporter: Michael Dürig > Assignee: Andrei Dulceanu > Labels: production > Fix For: Segment Tar 0.0.12 > > Attachments: OAK-4618-01.patch > > > The {{GCMonitorMBean}} MBean still dates back to the old {{oak-segment}}. We > need to review its endpoints and only keep those that make sense for > {{oak-segment-tar}}, adapt the others as necessary any add further > functionality as required. > Specifically I think we should get rid of the time series for > {{getRepositorySize()}} and {{getReclaimedSize()}}. > Also the name {{getRepositorySize()}} is confusing and we should change it. > It leads callers to think it would return current size of the repository > opposed to the size it had after the last cleanup. (There is > {{FileStoreStatsMBean.getRepositorySize()}} for the latter.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)