[
https://issues.apache.org/jira/browse/OAK-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432273#comment-15432273
]
Chetan Mehrotra commented on OAK-1312:
--------------------------------------
Thanks [~mreutegg] for the review. Attached is [updated
patch|^OAK-1312-review-v2.diff] and also updated the git branch
bq. DocumentNodeStore.dispose() closes the BundlingConflictHandler and logs a
warn message when the close method throws an IOException. The message does not
reference the second parameter.
Ack and done
bq. DocumentNodeStore.getBundlingHandler() is a bit misleading because it
creates a new bundling handler on each call. It is also a convenience method
for getBundlingConfigHandler().newBundllingHandler(). Maybe get rid of
getBundlingHandler()?
Makes sense. Done
bq. DocumentNodeStore#bundlingEnabled is only used in the constructor and can
be removed.
Done
bq. There are TODOs in CommitDiff. Is something missing here and the
implementation does not behave correctly or is it simply not optimized?
Removed one stale TODO and only one is left which I have now clarified i.e. one
around nodetype change
bq. Wouldn't it be cheaper to pass the bundlingContext as is to the
DocumentNodeState constructor in withRootRevision() and fromExternalChange()?
Makes sense. Done
bq. Bundling needs to be enabled first before it can be used. Should we rather
have an option instead to disable it? A configuration is needed anyway to make
use of the feature.
Makes sense. Changed the semantics to disabled one
> Bundle nodes into a document
> ----------------------------
>
> Key: OAK-1312
> URL: https://issues.apache.org/jira/browse/OAK-1312
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, documentmk
> Reporter: Marcel Reutegger
> Assignee: Chetan Mehrotra
> Labels: performance
> Fix For: 1.6
>
> Attachments: OAK-1312-review-v1.diff, OAK-1312-review-v2.diff
>
>
> For very fine grained content with many nodes and only few properties per
> node it would be more efficient to bundle multiple nodes into a single
> MongoDB document. Mostly reading would benefit because there are less
> roundtrips to the backend. At the same time storage footprint would be lower
> because metadata overhead is per document.
> Feature branch -
> https://github.com/chetanmeh/jackrabbit-oak/compare/trunk...chetanmeh:OAK-1312
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
