Konrad Windszus created OAK-4696:
------------------------------------
Summary: Improve logging for SyncHandler
Key: OAK-4696
URL: https://issues.apache.org/jira/browse/OAK-4696
Project: Jackrabbit Oak
Issue Type: Bug
Components: auth-external
Affects Versions: 1.5.8
Reporter: Konrad Windszus
In the {{ExternalLoginModule.syncUser}} the {{context.sync(..)}} is being
called without evaluating the return value at all
(https://github.com/apache/jackrabbit-oak/blob/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java#L354).
The return value should be logged to find out, which sync took place at all.
Also I am wondering if it would make sense to do the {{root.commit()}} only
conditionally in case the return value is not {{SyncResult.NOP}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
