[
https://issues.apache.org/jira/browse/OAK-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434879#comment-15434879
]
Konrad Windszus commented on OAK-4443:
--------------------------------------
With the introduction of the additional debug method the logging now has some
potential performance drawback.
In the past the logging was done like this:
{code}
if (log.isDebugEnabled()) {
log.debug("syncUser({}) {}", user.getId(),
timer.getString());
}
{code}
That means that the potentially expensive calls to {{user.getId()}} and
{{timer.getString()}} would only be issued in case log level DEBUG is really
enabled. With your refactoring those calls are always being executed and the if
condition in
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java#L425
becomes useless, because slf4j will internally guard everything with a similar
if condition. Compare also with
http://www.slf4j.org/faq.html#logging_performance.
> ExternalLoginModule: refactor to handle all reasons for 'ignore' together
> -------------------------------------------------------------------------
>
> Key: OAK-4443
> URL: https://issues.apache.org/jira/browse/OAK-4443
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
> Reporter: angela
> Assignee: angela
> Priority: Minor
> Attachments: OAK-4443.patch
>
>
> while working on OAK-4417 i found {{ExternalLoginModule.login}} a bit hard to
> read... in particular the 3 reasons that prevent accessing the IDP are not
> handled together.
> the proposed patch slightly refactors {{ExternalLoginModule}}. [~tripod],
> maybe you want to take a quick look? otherwise i will go ahead and commit it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
