[ 
https://issues.apache.org/jira/browse/OAK-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440096#comment-15440096
 ] 

Matt Ryan commented on OAK-4712:
--------------------------------

Some questions that need to be resolved:
# For the request to query the sync state of a file, should the file name 
provided be a full path to a local file or a path to a file within OAK (e.g. 
/content/dam/myimage.jpg)?  Current implementation uses a local file path but I 
have been wondering if it should be an OAK path.
# For the request to query the sync state of a file, when converting from the 
externally-supplied file name to an internal DataIdentifier, this 
implementation is performing the same calculation to determine the internal ID 
name as is done when a file is stored.  I have a number of concerns with this:
   - It is inefficient - the entire file has to be read and digested in order 
to compute the internal ID.  This takes a long time for large assets.
   - I've essentially duplicated the logic from CachingDataStore into 
S3DataStore to compute the internal ID.  I hate duplicating the code, but I am 
trying to avoid exposing internal IDs in API, and I am not seeing a good way in 
the current implementation to avoid this without either modifying public API to 
CachingDataStore, or exposing the internal ID via API, or both.

> Publish S3DataStore stats in JMX MBean
> --------------------------------------
>
>                 Key: OAK-4712
>                 URL: https://issues.apache.org/jira/browse/OAK-4712
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: blob
>            Reporter: Matt Ryan
>         Attachments: OAK-4712.1.diff
>
>
> This feature is to publish statistics about the S3DataStore via a JMX MBean.  
> There are two statistics suggested:
> * Indicate the number of files actively being synchronized from the local 
> cache into S3
> * Given a path to a local file, indicate whether synchronization of file into 
> S3 has completed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to