[
https://issues.apache.org/jira/browse/OAK-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francesco Mari resolved OAK-4349.
---------------------------------
Resolution: Won't Fix
Resolving this issue as won't fix, since the described situation doesn't seem
to be a problem. Recent work (see OAK-4650 and linked issue) seems to suggest
that decoupling command line utilities in a front- and back-end part is a
better approach to defeat complexity in oak-run.
> Commands in oak-run should not implement NodeStore creation logic from scratch
> ------------------------------------------------------------------------------
>
> Key: OAK-4349
> URL: https://issues.apache.org/jira/browse/OAK-4349
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: run
> Reporter: Francesco Mari
> Assignee: Francesco Mari
> Attachments: OAK-4349-01.patch, OAK-4349-02.patch
>
>
> Many commands in oak-run implement the same logic over and over to create a
> {{NodeStore}} from command line arguments. I think it would be better to have
> this logic in a single place and reuse it from every command.
> In OAK-4246 I proposed an approach based on URIs. Instead of specified
> command line arguments and flags, a connection to a specific backend could be
> specified using a URI with application specific schemas. On OAK-4246 I showed
> some examples specific to the {{SegmentNodeStore}}:
> - {{segment:///path/to/dir}} opens an "old style" segment store at the
> specified folder.
> - {{segment:tar:///path/to/dir}} opens a"new style" segment store at the
> specified folder.
> - {{segment:tar:///path/to/dir?mm=false}} opens a "new style" segment store
> at the specified folder and disables memory mapped files.
> A solution based on URIs can be extended to other {{NodeStore}}
> implementations by using other schemes like {{segment:mem}},
> {{document:mongo}}, {{document:rdb}}, and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
