[ 
https://issues.apache.org/jira/browse/OAK-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448217#comment-15448217
 ] 

Marcel Reutegger commented on OAK-4528:
---------------------------------------

It is a nice improvement. Whether the repository is able to serve listeners in 
time still depends on test parameters. E.g. if I increase the number of write 
sessions to 20, the queues will again fill up on my machine. Fetching changes 
from other cluster node(s) seems to be the critical path now (the documents 
they added).

> diff calculation in DocumentNodeStore should try to re-use journal info on 
> diff cache miss
> ------------------------------------------------------------------------------------------
>
>                 Key: OAK-4528
>                 URL: https://issues.apache.org/jira/browse/OAK-4528
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, documentmk
>            Reporter: Vikas Saurabh
>            Assignee: Marcel Reutegger
>            Priority: Minor
>              Labels: observation, resilience
>             Fix For: 1.6, 1.5.6
>
>         Attachments: queue-oak-4715.png, queue.png
>
>
> Currently, diff information is filled into caches actively (local commits 
> pushed in local_diff, externally read changes pushed into memory_diff). At 
> the time of event processing though, the entries could have already been 
> evicted.
> In that case, we fall back to computing diff by comparing 2 node-states which 
> becomes more and more expensive (and eventually fairly non-recoverable 
> leading to OAK-2683).
> To improve the situation somewhat, we can probably try to consult journal 
> entries to read a smaller-superset of changed paths before falling down to 
> comparison.
> /cc [~mreutegg], [~chetanm], [~egli]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to