[
https://issues.apache.org/jira/browse/OAK-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448391#comment-15448391
]
Francesco Mari commented on OAK-4719:
-------------------------------------
{{Files.delete()}} throws an {{IOException}} instead of returning {{false}}.
This allows the implementation to convey additional information with the
failure. {{File.delete()}} and his boolean return value does not provide any
additional detail about the failure. Quoting the Javadoc of {{File.delete()}}:
{quote}
Note that the java.nio.file.Files class defines the delete method to throw an
IOException when a file cannot be deleted. This is useful for error reporting
and to diagnose why a file cannot be deleted.
{quote}
> Marked files are not removed if compaction fails
> ------------------------------------------------
>
> Key: OAK-4719
> URL: https://issues.apache.org/jira/browse/OAK-4719
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
> Reporter: Francesco Mari
> Assignee: Francesco Mari
> Fix For: Segment Tar 0.0.12
>
>
> If compaction fails after the configured number of attempts, {{cleanup()}} is
> called to remove TAR files that might contain garbage generated during the
> compaction attempt. The files returned by this call are ignored, thus
> preventing this garbage from being removed from the system.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
