[
https://issues.apache.org/jira/browse/OAK-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella closed OAK-4686.
---------------------------------
Bulk close for 1.5.9
> DocumentNodeStoreTest#compareOnBranch fails for update.limit=10000
> ------------------------------------------------------------------
>
> Key: OAK-4686
> URL: https://issues.apache.org/jira/browse/OAK-4686
> Project: Jackrabbit Oak
> Issue Type: Task
> Reporter: Vikas Saurabh
> Assignee: Vikas Saurabh
> Priority: Minor
> Fix For: 1.6, 1.5.9
>
>
> I think this started with recent improvements to not drop to {{Persisted}} if
> update limit isn't hit. Following change to the test makes it pass:
> {noformat}
> diff --git
> a/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreTest.java
>
> b/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreTest.java
> index 35ee306..c52e32d 100644
> ---
> a/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreTest.java
> +++
> b/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreTest.java
> @@ -2566,7 +2566,10 @@ public class DocumentNodeStoreTest {
> builder.child("parent").child("node-x").child("child").child("x");
> b.setRoot(builder.getNodeState());
> // branch state is now InMemory
> - builder.child("b");
> +// builder.child("b");
> + for (int i = 0; i < DocumentRootBuilder.UPDATE_LIMIT; i++) {
> + builder.child("b" + i);
> + }
> b.setRoot(builder.getNodeState());
> // branch state is now Persisted
> builder.child("c");
> {noformat}
> Thanks [~chetanm] for spotting this. [~mreutegg], is it ok to update the test?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
