[
https://issues.apache.org/jira/browse/OAK-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amit Jain updated OAK-4712:
---------------------------
Attachment: OAK_4712_6_Amit.patch
[~mattvryan] I made some changes and attaching the patch here.
* Used PathUtils to parse the input path - helps in validating the paths
* Minor code changes for conditions at couple places minor doc changes
* Some changes in the S3DataStoreStatsTest (WIP)
** Removed usage of the test file
Regards to the test there are some changes that I suggest:
* Move parts that require configuration of the S3DS to oak-blob-cloud module
itself into a new test.
* Use a mocked S3DS in the S3DataStoreStatsTest class
** Instead of mocking node store use MemoryNodeStore.
** Add tests for multiple props, prop with binary property and a couple of test
for different paths to test the logic in the S3DataStoreStats
** Possibly also remove the JMX registration logic and add a test in the
SegmentNodeStoreServiceTest to test registration. i.e. directly working with
S3DataStoreStats object.
Let me know what you think.
> Publish S3DataStore stats in JMX MBean
> --------------------------------------
>
> Key: OAK-4712
> URL: https://issues.apache.org/jira/browse/OAK-4712
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: blob
> Reporter: Matt Ryan
> Assignee: Amit Jain
> Attachments: OAK-4712.2.diff, OAK-4712.3.diff, OAK-4712.4.diff,
> OAK-4712.5.diff, OAK_4712_6_Amit.patch
>
>
> This feature is to publish statistics about the S3DataStore via a JMX MBean.
> There are two statistics suggested:
> * Indicate the number of files actively being synchronized from the local
> cache into S3
> * Given a path to a local file, indicate whether synchronization of file into
> S3 has completed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
