[ 
https://issues.apache.org/jira/browse/OAK-4803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490303#comment-15490303
 ] 

Francesco Mari edited comment on OAK-4803 at 9/15/16 9:11 AM:
--------------------------------------------------------------

The patch implements everything that is described in the issue and adds unit 
tests for the newly introduced components. Some unnecessary components like 
{{StandbyStore}}, {{SegmentLoaderHandler}}, {{StandbyClientHandler}}, and other 
encoders and decoders have been removed as part of this patch.


was (Author: frm):
The patch implements everything that is describing in the issue and adds unit 
tests for the newly introduced components. Some unnecessary components like 
{{StandbyStore}}, {{SegmentLoaderHandler}}, {{StandbyClientHandler}}, and other 
encoders and decoders have been removed as part of this patch.

> Simplify the client side of the cold standby
> --------------------------------------------
>
>                 Key: OAK-4803
>                 URL: https://issues.apache.org/jira/browse/OAK-4803
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: Segment Tar 0.0.12
>
>         Attachments: OAK-4803-01.patch
>
>
> The implementation of the cold standby client is overly and unnecessarily 
> complicated. It would be way clearer to separate the client code in two major 
> components: a simple client responsible for sending messages to and receive 
> responses from the standby server, and the synchronization algorithm used to 
> read data from the server and to save read data in the local {{FileStore}}.
> Moreover, the client simple client could be further modularised by 
> encapsulating request encoding, response decoding and message handling into 
> their own Netty handlers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to