[ 
https://issues.apache.org/jira/browse/OAK-4043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502478#comment-15502478
 ] 

Chetan Mehrotra commented on OAK-4043:
--------------------------------------

Patch look fine. Without this patch {{rm-unreferenced}}

{noformat}
$java -jar oak-run-1.6-SNAPSHOT.jar checkpoints --segment=true  
/path/to/segmentstore rm-unreferenced
Apache Jackrabbit Oak 1.6-SNAPSHOT
Checkpoints /path/to/segmentstore
Referenced checkpoint from /:async@async is bcda394b-9a01-45e2-a326-bab1618ac60e
Removed 1 checkpoints in 112ms.
{noformat}

With this fix
{noformat}
$ java -jar oak-run-1.6-SNAPSHOT.jar checkpoints --segment=true  
/path/to/segmentstore rm-unreferenced
Apache Jackrabbit Oak 1.6-SNAPSHOT
Checkpoints /path/to/segmentstore
Referenced checkpoint from /:async@async is bcda394b-9a01-45e2-a326-bab1618ac60e
Referenced checkpoint from /:async@fulltext-async is 
46dce134-fe32-4929-84bf-abbd0ed46d9d
Removed 0 checkpoints in 65ms.
{noformat}

[~mreutegg] Just to be double safe here can you also review the changes around 
checkpoint handling for DocumentNodeStore

[~alex.parvulescu] In addition to this we should add a check in 
{{Oak#withAsyncIndexing(java.lang.String, long)}} to enforce this convention 
around checkpoint name i.e. name ending with {{async}}

> Oak run checkpoints needs to account for multiple index lanes
> -------------------------------------------------------------
>
>                 Key: OAK-4043
>                 URL: https://issues.apache.org/jira/browse/OAK-4043
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, run
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>            Priority: Critical
>              Labels: candidate_oak_1_4
>             Fix For: 1.6, 1.5.11
>
>         Attachments: OAK-4043.patch
>
>
> Oak run {{checkpoints rm-unreferenced}} [0] currently is hardcoded on a 
> single checkpoint reference (the default one). Now is it possible to add 
> multiple lanes, which we already did in AEM, but the checkpoint tool is 
> blissfully unaware of this and it might trigger a full reindex following 
> offline compaction.
> fyi [~edivad], [~chetanm]
> [0] https://github.com/apache/jackrabbit-oak/tree/trunk/oak-run#checkpoints



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to