Michael Dürig commented on OAK-4765:

LGTM. I would use replace the magic numbers in 
{{FileStore.newCancelCompactionCondition()}} with an enum though, which could 
also incorporate the reason string. 

Also could we improve the log messages of the places where the compaction 
condition is used and include the reason if compaction is cancelled?

> Provide option to interrupt online revision cleanup
> ---------------------------------------------------
>                 Key: OAK-4765
>                 URL: https://issues.apache.org/jira/browse/OAK-4765
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar, segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>              Labels: compaction, gc
>             Fix For: Segment Tar 0.0.14
>         Attachments: OAK-4765-v0.patch
> JMX binding for stopping a running compaction process

This message was sent by Atlassian JIRA

Reply via email to