[
https://issues.apache.org/jira/browse/OAK-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510213#comment-15510213
]
Andrei Dulceanu edited comment on OAK-4813 at 9/21/16 3:06 PM:
---------------------------------------------------------------
This comes hand in hand with OAK-4803 and aims to simplify the
{{StandbyServer}} code by moving all JMX related stuff into a new class,
{{StandbyServerSync}}. Other important changes
* Removed {{FileStore}} reference from {{StandbyServer}}. The fileStore is now
acquired using a {{StoreProvider}}, currently implemented by
{{StandbyServerSync}}
* Updated {{StandbyServer}} and {{StandbyClient}} to use the latest
{{SslContextBuilder}} from netty in favour of old deprecated methods
[~mduerig], could you review this patch, please?
/cc [~alexparvulescu], [~frm]
was (Author: dulceanu):
This comes hand in hand with OAK-4803 and aims to simplify the
{{StandbyServer}} code by moving all JMX related stuff into a new class,
{{StandbyServerSync}}. Other important changes
* Removed {{FileStore}} reference from {{StandbyServer}}. The fileStore is now
acquired using a {{StoreProvider}}, currently implemented by
{{StandbyServerSync}}
* Updated {{StandbyServer}} and {{StandbyClient}} to use the latest
{{SslContextBuilder}} from netty in favour of old deprecated methods
[~mduerig], could you please review this patch, please?
/cc [~alexparvulescu], [~frm]
> Simplify the server side of cold standby
> ----------------------------------------
>
> Key: OAK-4813
> URL: https://issues.apache.org/jira/browse/OAK-4813
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Andrei Dulceanu
> Assignee: Andrei Dulceanu
> Priority: Minor
> Fix For: Segment Tar 0.0.14
>
> Attachments: OAK-4813-01.patch
>
>
> With the changes introduced in OAK-4803, it would be nice to keep the
> previous symmetry between the client and server and remove thus the
> {{FileStore}} reference from the latter.
> Per [~frm]'s suggestion from one of the comments in OAK-4803:
> bq. In the end, these are the only three lines where the FileStore is used in
> the server, which already suggests that this separation of concerns exists -
> at least at the level of the handlers.
> {code:java}
> p.addLast(new GetHeadRequestHandler(new DefaultStandbyHeadReader(store)));
> p.addLast(new GetSegmentRequestHandler(new
> DefaultStandbySegmentReader(store)));
> p.addLast(new GetBlobRequestHandler(new DefaultStandbyBlobReader(store)));
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
