Alex Parvulescu commented on OAK-4371:

bq. Otherwise I suggest to remove this check and recommend external monitoring 
as suggested in my previous comment.
I think this makes the most sense. the async checkpoint cleanup code is a lot 
more resilient so we don't really need this extra warning anymore.

> Overly zealous warning about checkpoints on compaction 
> -------------------------------------------------------
>                 Key: OAK-4371
>                 URL: https://issues.apache.org/jira/browse/OAK-4371
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar, segmentmk
>            Reporter: Michael Dürig
>              Labels: compaction, gc, logging
>             Fix For: Segment Tar 0.0.14
> {{FileStore.compact}} logs a warning {{TarMK GC #{}: compaction found {} 
> checkpoints, you might need to run checkpoint cleanup}} if there is more than 
> a single checkpoints. 
> AFIK this is now the norm as async indexing has uses 2 checkpoints 
> ([~chetanm], [~edivad] please clarify). 
> In any case should we improve this and not hard code any number of expected 
> checkpoints. Maybe make the threshold configurable?

This message was sent by Atlassian JIRA

Reply via email to