[
https://issues.apache.org/jira/browse/OAK-4843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533139#comment-15533139
]
Francesco Mari commented on OAK-4843:
-------------------------------------
I like the fact that this patch cleanly separates the API and the
implementation for the backup and restore functionality. I think, though, that
exporting the backup package is premature. As [~mduerig] outlined, exporting
that package means exporting interfaces that should remain an internal API of
the bundle. I will go ahead and partially commit the proposed patch. I will
open another issue to track the need for a better backup and restore API, which
is something we should consider after the first stable release of
oak-segment-tar.
> Missing export for org.apache.jackrabbit.oak.backup package
> -----------------------------------------------------------
>
> Key: OAK-4843
> URL: https://issues.apache.org/jira/browse/OAK-4843
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
> Reporter: Michael Dürig
> Assignee: Andrei Dulceanu
> Labels: API, OSGi
> Fix For: Segment Tar 0.0.14
>
> Attachments: OAK-4843-01.patch
>
>
> Oak segment tar does not export {{org.apache.jackrabbit.oak.backup}}, which
> makes backup restore functionality unavailable from OSGi containers.
> Instead of just exporting this package I think we should:
> * Separate API from implementation
> * Add semantic versioning to the exported API
> /cc [~frm]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
