[
https://issues.apache.org/jira/browse/OAK-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552536#comment-15552536
]
Valentin Olteanu edited comment on OAK-4901 at 10/7/16 7:52 AM:
----------------------------------------------------------------
[~alex.parvulescu] could you please review the attached patch? Thanks!
PS: I've just realized the patch has an unwanted change in {{pom.xml}} which
should be ignored.
was (Author: volteanu):
[~alex.parvulescu] could you please review the attached patch? Thanks!
> Improve SizeDeltaGcEstimation logging
> -------------------------------------
>
> Key: OAK-4901
> URL: https://issues.apache.org/jira/browse/OAK-4901
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Affects Versions: Segment Tar 0.0.14
> Reporter: Valentin Olteanu
> Priority: Minor
> Attachments: OAK-4901.patch
>
>
> The current message logged after estimation is not very clear for someone
> that does not know how it works:
> {code}
> 06.10.2016 18:53:07.819 *INFO* [TarMK revision gc
> [/Users/volteanu/workspace/test/author/crx-quickstart/repository/segmentstore]]
> org.apache.jackrabbit.oak.segment.file.FileStore TarMK GC #1: estimation
> completed in 7.362 ms (7 ms). Size delta is 0% or 880.3 MB/880.9 MB
> (880258560/880892416 bytes), so skipping compaction for now
> {code}
> I think it should also list the delta in absolute value and the threshold it
> is compared against.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
