Michael Dürig commented on OAK-4919:

Initial proposal: 
 (This is the latest commit of 
https://github.com/mduerig/jackrabbit-oak/commits/OAK-4919, which also includes 
the pending changes for OAK-4617)

The idea is that you can pass a supplier for a status message to 
{{RevisionGC}}, which is called by the latter whenever its status is queried. 
The methods for starting and cancelling a revision gc just fire of a respective 
background operation (an instance of {{ManagmentOperation}}). Their return 
value indicate whether firing the background operation succeeded or failed 
(e.g. because gc is running already). The status of the background operation 
itself would need to be queried through {{RevisionGC.getRevisionGCStatus()}}.

[~alex.parvulescu], WDYT?
[~mreutegg], please provide feedback wrt. the document node store. 

> Better feedback from method invocations on RevisionGCMBean
> ----------------------------------------------------------
>                 Key: OAK-4919
>                 URL: https://issues.apache.org/jira/browse/OAK-4919
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: monitoring
>             Fix For: 1.5.13
> The methods to invoke and cancel revision gc return void. This is by design 
> as those calls are asynchronous. The idea is that 
> {{RevisionGC.getRevisionGCStatus()}} would return the current status of an 
> ongoing gc operation. However, currently that method only returns the status 
> of the asynchronous task that was fired off. It should instead be able to 
> convey back the real status of the underlying operation. 

This message was sent by Atlassian JIRA

Reply via email to