[ 
https://issues.apache.org/jira/browse/OAK-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568003#comment-15568003
 ] 

Amit Jain commented on OAK-4837:
--------------------------------

[~tmueller] Can you please review the change.

I create couple of gists to make it easier to review the changes
* The core of the implementation is 
https://gist.github.com/amit-jain/5cdb51d8ba2a4d90fcf754806b6c3ba0
* The tests are part of gist 
https://gist.github.com/amit-jain/f2f1a6eee389470fe2beddbf285c1870

OAK-4870 then uses this to implement the S3DataStore.


> Improved caching for DataStore
> ------------------------------
>
>                 Key: OAK-4837
>                 URL: https://issues.apache.org/jira/browse/OAK-4837
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: blob
>            Reporter: Amit Jain
>            Assignee: Amit Jain
>              Labels: performance
>
> The current CachingDataStore implementation used with S3DataStore has certain 
> problems:
> * Lack of stats to show hit rate/miss rates for files being requested for 
> downloads
> * Lack of stats for async uploads
> * CachingDataStore starts proactively downloading files in the background 
> when a call to {{getRecord}} is made.
> * Async upload functionality leaks into Backend implementations, LocalCache 
> classes.
> * The call to {{DataStore#getRecord()}} which makes multiple calls to 
> backends which is problematic for S3 (i.e. when not being served bu cache)
> * There is some functionality which is not used with Oak like length cache, 
> sync/async touch etc. which can be removed and code simplified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to