Stefan Egli resolved OAK-4924.
    Resolution: Invalid
      Assignee: Stefan Egli

Chetan's right, its ok there to pass null (or EMPTY, but that's equivalent and 
only a detail in this context). I was confusing this with assuming that commit 
hooks (thus the ChangeCollector) would be applied afterwards - which it isn't 
of course, it's just a direct notification to the Observers.

Which means that given the ChangeCollector is part of the commit hook execution 
(only), it can't be applied in this case. Which means that we can't prefilter 
async index updates - which is somewhat suboptimal. So if we wanted to fix that 
we'd have to find another solution - but that's independent of this null.

Hence closing this ticket as invalid. Thx!

> avoid CommitInfo==null in contentChanged call in SegmentNodeStore.refresh
> -------------------------------------------------------------------------
>                 Key: OAK-4924
>                 URL: https://issues.apache.org/jira/browse/OAK-4924
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segmentmk
>    Affects Versions: 1.5.12
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>             Fix For: 1.6
> Currently 
> [SegmentNodeStore.refreshHead|https://github.com/apache/jackrabbit-oak/blob/d82f9b21d02a7eaf856f546e778118161d71b760/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStore.java#L231]
>  calls {{contentChanged}} with null as the CommitInfo. This is problematic 
> for prefiltering (OAK-4796, OAK-4907 et al) as for that a ChangeSet of 
> changed items in a commit is stored in the CommitContext in the CommitInfo.
> Thus it would be useful to not send null but a CommitInfo that has the 
> equivalent meaning of null but is a new object for each call (so that the 
> ChangeSet can be set).
> [~mduerig], [~frm], [~alex.parvulescu] wdyt?

This message was sent by Atlassian JIRA

Reply via email to