[ 
https://issues.apache.org/jira/browse/OAK-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568522#comment-15568522
 ] 

Francesco Mari edited comment on OAK-4883 at 10/12/16 11:59 AM:
----------------------------------------------------------------

I was bad at line counting. The incriminating line is [this 
one|https://github.com/tmaret/jackrabbit-oak/blob/OAK-4883/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java#L340].
 The 'false' literal passed to toBoolean() is not used for comparison, but as a 
default value in case the value for the 'standby' property is not provided or 
invalid. As such, that method will effectively register a NodeStore only if the 
'standby' property is true: that condition should be reversed. The rest of the 
patch is correct, since it always register a BlobGCMBean independently from the 
value of the 'standby' property, disabling observation in the SegmentNodeStore 
if 'standby' is true.


was (Author: frm):
I was bad at line counting. The incriminating line is [this 
one|https://github.com/tmaret/jackrabbit-oak/blob/OAK-4883/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreService.java#L340].
 The 'false' literal passed to toBoolean() is not used for comparison, but as a 
default value in case the value for the 'standby' property is not provided or 
invalid. As such, that line will effectively register a NodeStore only if the 
'standby' property is true: that condition should be reverted. The rest of the 
patch is correct, since it always register a BlobGCMBean independently from the 
value of the 'standby' property, disabling observation in the SegmentNodeStore 
if 'standby' is true.

> Missing BlobGarbageCollection MBean on standby instance
> -------------------------------------------------------
>
>                 Key: OAK-4883
>                 URL: https://issues.apache.org/jira/browse/OAK-4883
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar, segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Timothee Maret
>              Labels: gc
>         Attachments: OAK-4883.patch
>
>
> The {{BlobGarbageCollection}} MBean is no longer available on a standby 
> instance, this affects non-shared datastore setups (on a shared datastore 
> you'd only need to run blob gc on the primary).
> This change was introduced by OAK-4089 (and backported to 1.4 branch with 
> OAK-4093).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to