[ 
https://issues.apache.org/jira/browse/OAK-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568518#comment-15568518
 ] 

Alex Parvulescu edited comment on OAK-4450 at 10/12/16 12:51 PM:
-----------------------------------------------------------------

attaching changes needed in oak-run once this is applied and the dependency is 
updated (includes change in pom.xml file needed just to testing this stuff out).


was (Author: alex.parvulescu):
attaching changes needed in oak-run once this is applied and the dependency is 
updated (includes change in pom.xml file needed just to testing this stuff out).
[edit] removed the attachment, I had forgotten to update some code.

> Properly split the FileStore into read-only and r/w variants 
> -------------------------------------------------------------
>
>                 Key: OAK-4450
>                 URL: https://issues.apache.org/jira/browse/OAK-4450
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: technical_debt
>             Fix For: Segment Tar 0.0.18
>
>         Attachments: OAK-4450-oak-run.patch
>
>
> The {{ReadOnlyFileStore}} class currently simply overrides the {{FileStore}} 
> class replacing all mutator methods with a trivial implementation. This 
> approach however leaks into its ancestor as the read only store needs to pass 
> a flag to the constructor of its super class so some fields can be 
> instantiated properly for the read only case. 
> We should clean this up to properly separate the read only and the r/w store. 
> Most likely we should factor the commonalities into a common, abstract base 
> class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to