[ 
https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571155#comment-15571155
 ] 

Thomas Mueller commented on OAK-4522:
-------------------------------------

http://svn.apache.org/r1764611 (fix test case)

Actually the test case was "broken" before the above changes: it was relying on 
thread timing. Now the test uses an implementation detail of the 
CommitRateLimiter, which is also slightly bad, but I don't see an alternative. 
Also, the test is now faster.

> Improve CommitRateLimiter to optionally block some commits
> ----------------------------------------------------------
>
>                 Key: OAK-4522
>                 URL: https://issues.apache.org/jira/browse/OAK-4522
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: jcr
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>              Labels: observation
>             Fix For: 1.5.12
>
>         Attachments: OAK-4522-b.patch, OAK-4522-c.patch, OAK-4522.patch
>
>
> The CommitRateLimiter of OAK-1659 can delay commits, but doesn't currently 
> block them, and delays even those commits that are part of handling events. 
> Because of that, the queue can still get full, and possibly delaying commits 
> while handling events can make the situation even worse.
> In Jackrabbit 2.x, we had a similar feature: JCR-2402. Also related is 
> JCR-2746.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to