[ 
https://issues.apache.org/jira/browse/OAK-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581351#comment-15581351
 ] 

Chetan Mehrotra commented on OAK-4937:
--------------------------------------

Given that JournalGC was not passing in ID as part of UpdateOp we would need to 
see what impact it would have had on existing setups on Mongo where this logic 
worked silently.

bq. RDBDocumentStore and MemoryDocumentStore share the same logic and use 
UpdateUtils.applyChanges

[~julian.resc...@gmx.de] Note that test was passing for 
{{MemoryDocumentStore}}. Also current Journal test run against 
{{MemoryDocumentStore}}

> JournalGC failing with RDB DocumentStore
> ----------------------------------------
>
>                 Key: OAK-4937
>                 URL: https://issues.apache.org/jira/browse/OAK-4937
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: documentmk, rdbmk
>    Affects Versions: 1.5.6, 1.4.8
>            Reporter: Chetan Mehrotra
>            Assignee: Julian Reschke
>             Fix For: 1.4.9, 1.5.13
>
>         Attachments: OAK-4937-v1.patch
>
>
> Journal GC on RDB DocumentStore fails with following exception
> {noformat}
> org.apache.jackrabbit.oak.plugins.document.DocumentStoreException: Can't 
> insert the document: null
>       at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.internalCreateOrUpdate(RDBDocumentStore.java:1216)
>       at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.createOrUpdate(RDBDocumentStore.java:295)
>       at 
> org.apache.jackrabbit.oak.plugins.document.util.LeaseCheckDocumentStoreWrapper.createOrUpdate(LeaseCheckDocumentStoreWrapper.java:128)
>       at 
> org.apache.jackrabbit.oak.plugins.document.JournalGarbageCollector.updateTailTimestamp(JournalGarbageCollector.java:167)
>       at 
> org.apache.jackrabbit.oak.plugins.document.JournalGarbageCollector.gc(JournalGarbageCollector.java:112)
>       at 
> org.apache.jackrabbit.oak.plugins.document.JournalGCIT.journalGCSimpleInvocation(JournalGCIT.java:42)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to