Chetan Mehrotra commented on OAK-4940:

Okie in that case makes sense to keep that also. May be keep it simple and have 
a single set for nodetype/mixin of all changed nodes but have support in Filter 
to express the intent precisely

> Consider collecting grand-parent changes in ChangeSet
> -----------------------------------------------------
>                 Key: OAK-4940
>                 URL: https://issues.apache.org/jira/browse/OAK-4940
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.5.12
>            Reporter: Stefan Egli
>             Fix For: 1.6
> At the moment the ChangeSet, which is populated by ChangeCollectorProvider (a 
> Validator) during a commit, collects changed property names, as well as node 
> name, node type and path of the parent (whereas _parent_ for a property 
> change is its node, while for a node change is actually its parent).
> For improvements such as SLING-6163 it might be valuable to collect 
> grand-parent changes (node name, node type and perhaps path) too. We could 
> extend the ChangeSet with additional, explicit grand-parent sets (ie we 
> should not mix them with the parent changes as that would lessen filtering 
> rate)

This message was sent by Atlassian JIRA

Reply via email to