Francesco Mari commented on OAK-2498:

In an offline conversation with [~mduerig] and [~alex.parvulescu] we figured 
out that we need to add the following types to the ones currently recognized by 
the system.
- Binary reference. This has to be used when parsing the segment to detect 
binary reference records. Detecting binary references is necessary when 
maintaining the index of external binary references in the TAR writer up to 
- List of property names. A list of strings, where every string is a property 
name, is referenced by the template record.
- List of list of values. This list is pointed to by the node record and 
contains the values for single\- and multi\- value properties of that node. The 
double indirection is needed to support multi-value properties.
- Map from string to node. This map is referenced by the template and 
represents the child relationship between nodes.
- Super root. This is a marker type identifying top-level records for the 
repository super-roots.
I will go ahead with the implementation and keep this issue up to date. As 
[~mduerig] suggested, the implementation should probably include a segment 
parser to validate the correctness of the serialization format.

> Root record references provide too little context for parsing a segment
> -----------------------------------------------------------------------
>                 Key: OAK-2498
>                 URL: https://issues.apache.org/jira/browse/OAK-2498
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Francesco Mari
>              Labels: tools
>             Fix For: Segment Tar 0.0.16
> According to the [documentation | 
> http://jackrabbit.apache.org/oak/docs/nodestore/segmentmk.html] the root 
> record references in a segment header provide enough context for parsing all 
> records within this segment without any external information. 
> Turns out this is not true: if a root record reference turns e.g. to a list 
> record. The items in that list are record ids of unknown type. So even though 
> those records might live in the same segment, we can't parse them as we don't 
> know their type. 

This message was sent by Atlassian JIRA

Reply via email to